urfuwo / hlx-test

Apache License 2.0
0 stars 3 forks source link

355: Fix sizing of TOC column in article grid. #490

Closed rjwtrmn closed 5 months ago

rjwtrmn commented 5 months ago

Currently as margins are added to the grid content rather than the grid itself, the column widths are not calculated correctly. If we add margins on the grid level rather than section and add negative margin and padding to sections with background colour (and hero) we can ensure the correct sizing. It also happened that the toc hide/show metadata config wasn't being read correctly so that is also resolved here. If it was intended for TOC to be mandatory on all article pages I can revert that change.

Fix #355

Test URLs: Content Hub: Before: https://main--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy After: https://355-article-page-grid-refactor--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy Before: https://main--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy-without-toc After: https://355-article-page-grid-refactor--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy-without-toc Before: https://main--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy-full-background After: https://355-article-page-grid-refactor--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy-full-background

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [0d44c93](https://github.com/urfuwo/hlx-test/commit/0d44c93cd6bfe9a2e8ef81c7e8be0aab6ac5fb25) :white_check_mark: (latest) * [3247523](https://github.com/urfuwo/hlx-test/commit/324752374413ca0f7bb74bd6f0b84bf076fe5865) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/draft/rjwtrmn/the-article-copy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/draft/rjwtrmn/the-article-copy-full-background PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/draft/rjwtrmn/the-article-copy-without-toc PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI