urfuwo / hlx-test

Apache License 2.0
0 stars 3 forks source link

484 box sizing border box (3) #496

Closed eduardseifert closed 2 months ago

eduardseifert commented 2 months ago

Fix #484

Added universal star selector for box-sizing: border-box (normalization, reset, streamline).

Test URLs

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [d22d52f](https://github.com/urfuwo/hlx-test/commit/d22d52f65c0a171ce3ae50eacb85004139aeb35d) :white_check_mark: (latest) * [8510133](https://github.com/urfuwo/hlx-test/commit/8510133ef59ecc9597d1813a7d97fc97543808f7) :white_check_mark: * [db59d67](https://github.com/urfuwo/hlx-test/commit/db59d677b5a754564b440197ec2682b104a90b31) :white_check_mark: * [51b4bc1](https://github.com/urfuwo/hlx-test/commit/51b4bc1478f210f2735b9e02e11617e37bc5a303) :white_check_mark: * [fcf7a92](https://github.com/urfuwo/hlx-test/commit/fcf7a921476462999946768752e71614511df12e) :white_check_mark: * [54385f5](https://github.com/urfuwo/hlx-test/commit/54385f5040ec44e7126eb2413100618452f1354f) :white_check_mark: * [68b8e19](https://github.com/urfuwo/hlx-test/commit/68b8e1916f9544621759dba6b13b1e92fbc32263) :white_check_mark: * [a6bf6f2](https://github.com/urfuwo/hlx-test/commit/a6bf6f2c13fb99218f1fe4beefdabe8d97a3fbf9) :white_check_mark: * [68cbfac](https://github.com/urfuwo/hlx-test/commit/68cbfac15eba7583ea6d06ce8ffe105ed9773a32) :white_check_mark: * [80d11e2](https://github.com/urfuwo/hlx-test/commit/80d11e2b5afb55e155ae07094defb30f77ac5c9e) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/design/design-system PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
saurabh-khare commented 2 months ago

@eduardseifert I see problems on the content hub homepage https://484-box-sizing-border-box-rebase--hlx-test--urfuwo.hlx.page/topics/

Screenshot 2024-04-23 at 09 17 33

In mobile view, the active marker on main nav is not aligned.

Screenshot 2024-04-23 at 09 27 46
eduardseifert commented 2 months ago

@saurabh-khare This is exactly the typical problem with content-box. What shall we (I) do? Again drive-by fixing?

saurabh-khare commented 2 months ago

I would suggest we leave the universal reset for now. We may not know where do we induce regression on existing pages because of blocks that do not calculate sizing taking care of borders and paddings. We do it at block level for newer blocks introduced and later come back to this for fix all the known issues by looking extensively into the pages and letting SAP QA to find the regression issues.

alexcarol commented 2 months ago

Based on our last discussion, we'll fix the issues and proceed with merging so that we can take advantage of the new border-box setup.

eduardseifert commented 2 months ago

@saurabh-khare + @alexcarol As discussed, fixed the issues. Please take a look: https://484-box-sizing-border-box-rebase--hlx-test--urfuwo.hlx.page/topics/

eduardseifert commented 2 months ago

👊 💪