Closed eduardseifert closed 2 months ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/design/design-system |
@eduardseifert I see problems on the content hub homepage https://484-box-sizing-border-box-rebase--hlx-test--urfuwo.hlx.page/topics/
In mobile view, the active marker on main nav is not aligned.
@saurabh-khare This is exactly the typical problem with content-box
. What shall we (I) do? Again drive-by fixing?
I would suggest we leave the universal reset for now. We may not know where do we induce regression on existing pages because of blocks that do not calculate sizing taking care of borders and paddings. We do it at block level for newer blocks introduced and later come back to this for fix all the known issues by looking extensively into the pages and letting SAP QA to find the regression issues.
Based on our last discussion, we'll fix the issues and proceed with merging so that we can take advantage of the new border-box setup.
@saurabh-khare + @alexcarol As discussed, fixed the issues. Please take a look: https://484-box-sizing-border-box-rebase--hlx-test--urfuwo.hlx.page/topics/
👊 💪
Fix #484
Added universal star selector for box-sizing: border-box (normalization, reset, streamline).
Test URLs