urfuwo / hlx-test

Apache License 2.0
0 stars 3 forks source link

491: TOC sticky in mobile view #498

Closed rjwtrmn closed 2 months ago

rjwtrmn commented 2 months ago

Make TOC sticky for mobile. Added additional event handling to close menu on click outside/esc/focus out

Fix #491

Test URLs: Content Hub: Before: https://main--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy After: https://491-sticky-toc-mobile--hlx-test--urfuwo.hlx.live/draft/rjwtrmn/the-article-copy

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [b3d5e89](https://github.com/urfuwo/hlx-test/commit/b3d5e895432ab96928d86c7b0d608279c711251e) :white_check_mark: (latest)
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/draft/rjwtrmn/the-article-copy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
saurabh-khare commented 2 months ago
Screenshot 2024-04-23 at 12 31 13

This looks counterintuitive. We hide the heading itself when we go to it via TOC. May be it should scroll to the heading after the TOC like

Screenshot 2024-04-23 at 12 33 15

But let me put that to Elaine. It obstructs the view of the page.