urfuwo / hlx-test

Apache License 2.0
0 stars 3 forks source link

501: Fix content-list top spacing in sections with background and column sections #510

Closed rjwtrmn closed 2 months ago

rjwtrmn commented 2 months ago

This is a quick fix specifically for content list as this is causing a spacing issue on the main homepage. Ideally we need to rework how we apply spacing to the sections and blocks in hub and article pages so that it is more generic and individual blocks don't have to worry about specifying vertical margin/padding. We can address this on a more after we receive feedback from Elaine, with more explicit rules defined as to how spacing should be applied between elements.

Note: Content list currently a bit broken as tagging changes in progress.

Fix #501

Test URLs: Content Hub: Before: https://main--hlx-test--urfuwo.hlx.live/topics/ After: https://501-content-list-spacing--hlx-test--urfuwo.hlx.live/topics/ Before: https://main--hlx-test--urfuwo.hlx.live/design/stories-resources/ After: https://501-content-list-spacing--hlx-test--urfuwo.hlx.live/design/stories-resources/

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [868fd0a](https://github.com/urfuwo/hlx-test/commit/868fd0a4f17afc7f60ba95c8c8d8ad411135e09f) :white_check_mark: (latest)
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/design/stories-resources/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/topics/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI