513 when to use - Githubissues

eduardseifert commented 2 months ago

Fix #513

Added the new "When To Use" block in code and library
❗ Made some changes to general link handling in styles.css based on Frontify > @saurabh-khare Please have a look
Added Design System to the Sidekick library @alexcarol (link to Sidekick library does not work yet)

Test URLs: Content Hub: Before: https://main--hlx-test--urfuwo.hlx.page/topics/ After: https://513-when-to-use--hlx-test--urfuwo.hlx.page/topics/ (focus on the links, nothing changed)

Design system: Before: https://main--hlx-test--urfuwo.hlx.live/fiori-design-web/button-web-component After: https://513-when-to-use--hlx-test--urfuwo.hlx.page/fiori-design-web/button-web-component

[x] New Blocks introduced in this PR If yes, please provide details below

Block Name	Documentation	Library Link
when-to-use	doc-link + https://513-when-to-use--hlx-test--urfuwo.hlx.page/tools/sidekick/blocks/when-to-use	Library Link

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [1bc501c](https://github.com/urfuwo/hlx-test/commit/1bc501cc5cb74cc427f5e33d4150c87aee4e0086) :white_check_mark: (latest) * [8b6a613](https://github.com/urfuwo/hlx-test/commit/8b6a61339ee3d8f620d163ea381c1183fa114996) :white_check_mark: * [1514781](https://github.com/urfuwo/hlx-test/commit/1514781fa8978493662760a280badfc0b3ac3b3f) :white_check_mark: * [f7aa20f](https://github.com/urfuwo/hlx-test/commit/f7aa20f660db2e659a1d85405dcd6aa9ee5d7cc1) :white_check_mark:

aem-code-sync[bot] commented 2 months ago

Page	Scores	Audits	Google
/fiori-design-web/button-web-component
/tools/sidekick/blocks/when-to-use
/topics/

alexcarol commented 2 months ago

It doesn't quite match the design: Live site: This branch:

If it makes it easier you can always remove the explicit "do" and "don't" from the content and add it via code along with the icon (that's up to you).

eduardseifert commented 2 months ago

It doesn't quite match the design

The underline starts above 1280+. Please re-check.

eduardseifert commented 2 months ago

If it makes it easier you can always remove the explicit "do" and "don't" from the content and add it via code along with the icon (that's up to you).

I would like to keep the current implementation (the CSS selects the correspoding p).

urfuwo / hlx-test

513 when to use #533