uribo / zipangu

Japanese utility functions and data
https://uribo.github.io/zipangu
Other
56 stars 7 forks source link

Vectorize is_jholiday() #15

Closed yutannihilation closed 4 years ago

yutannihilation commented 4 years ago

これが動いてほしい...

zipangu::is_jholiday(as.Date(c("2019-01-01", "2020-01-01")))
#> Warning in if (checked == FALSE) rlang::warn("The year specified must be after
#> the law was enacted in 1948"): the condition has length > 1 and only the first
#> element will be used
#> Warning in if (is_current_law_yr(year)) {: the condition has length > 1 and only
#> the first element will be used
#> Warning in if (checked == FALSE) rlang::warn("The year specified must be after
#> the law was enacted in 1948"): the condition has length > 1 and only the first
#> element will be used
#> Warning in if (is_current_law_yr(year)) {: the condition has length > 1 and only
#> the first element will be used
#> Error in seq.int(0, lubridate::days_in_month(date_begin) - 1): 'to' must be of length 1

Created on 2020-04-05 by the reprex package (v0.3.0)

uribo commented 4 years ago

3c01ca58a4cf7676b448ed0983d8819aedf474f4 で対応しました!

yutannihilation commented 4 years ago

ありがとうございます!(もろもろベクトル化すべくPR準備中です...)