Fix is_jholiday date argument NA handling and week start day handling

uribo / zipangu

Japanese utility functions and data

https://uribo.github.io/zipangu

Other

56 stars 7 forks source link

Fix is_jholiday date argument NA handling and week start day handling #41

Closed hidekoji closed 2 years ago

hidekoji commented 2 years ago

This fixes https://github.com/uribo/zipangu/issues/39
This fixes #40

As for #39, added a logic to check if the date argument contains NA or not and make sure to exclude NA from yr so that lubridate::as_date(unlist(jholiday(yr, "en"))) won't fail.

As for #40, change it to pass week_start = 7 explicitly when calling lubridate::wday so that results become more stable.

uribo commented 2 years ago

Looks good! Can you add a NEWS.md entry, please?

hidekoji commented 2 years ago

I updated NEWS.md accordingly and appreciate your quick response!

uribo commented 2 years ago

Thanks!