uricamic / flandmark

Open-source implementation of facial landmark detector
http://cmp.felk.cvut.cz/~uricamic/flandmark/
GNU General Public License v3.0
228 stars 151 forks source link

Fix opencv build system #8

Closed sthalik closed 11 years ago

sthalik commented 11 years ago

In any case please apply the first thunk, typo precluding compilation of libflandmark without additional include paths. Keep in mind that CMake variables are case-sensitive. There are in fact 2 typos, s#OPENCV#OpenCV# s#DIR#DIRS#.

The second thunk ensures that all dependent objects get linked in; on Windows, OpenCV has a static 3rdparty zlib dependency which breaks shared build. This thunk may be dubious however as it's enlarging shared binary without -Wl,-as-needed or -flto. Gets rid of platform-specific stuff however.

uricamic commented 11 years ago

merged