urinieto / harmonixset

The Harmonix Set: Beats, Downbeats, and Structural Annotations for Pop Music
MIT License
149 stars 24 forks source link

fixed typos in segment labels #10

Closed bmcfee closed 2 years ago

bmcfee commented 2 years ago

This PR fixes a handful of typos in the segment labels. This only really matters when the typos are inconsistent within the same annotation (which they often are).

urinieto commented 2 years ago

Great thanks! I wanted to edit the CHANGELOG and also 0156_lastnight.txt, which wasn't updated like its JAMS counterpart, but I don't seem to have permissions to commit to your branch, @bmcfee. Could you give me access? (Here are some instructions: https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork). Maybe you have already done that and I'm doing something wrong?

bmcfee commented 2 years ago

You should have access already? (The box was already checked)

urinieto commented 2 years ago

Weird, I'm getting this error:


Username for 'https://github.com': urinieto
Password for 'https://urinieto@github.com':
remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
fatal: Authentication failed for 'https://github.com/bmcfee/harmonixset.git/'```

I just checked, and I can push to my repos. Any ideas how I could fix this?
eranegozy commented 2 years ago

Hi Uri,

You do need to go and generate a new access token and then use that as your password. Did you already do that?

Eran

On Oct 13, 2021, at 2:13 PM, Oriol Nieto @.***> wrote:

Weird, I'm getting this error:

Username for 'https://github.com': urinieto Password for @.***': remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead. remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information. fatal: Authentication failed for 'https://github.com/bmcfee/harmonixset.git/'```

I just checked, and I can push to my repos. Any ideas how I could fix this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/urinieto/harmonixset/pull/10#issuecomment-942586105, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACG2WTVWMOALDGBR4CBGQFTUGXD4LANCNFSM5F427FBQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

urinieto commented 2 years ago

Hey Eran, that worked, thanks! Just pushed the changes :)

eranegozy commented 2 years ago

👍🏻

-Eran (iPhone)

On Oct 13, 2021, at 5:59 PM, Oriol Nieto @.***> wrote:

 Hey Eran, that worked, thanks! Just pushed the changes :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.