search

urinieto / jams

A JSON Annotated Music Specification for Reproducible MIR Research
BSD 2-Clause "Simplified" License
13 stars 0 forks source link

isophonics_parser.py: Default confidence and context values #14

Closed ejhumphrey closed 10 years ago

ejhumphrey commented 10 years ago

Currently the isophonics parser sets confidence values to 1.0 and context to empty strings by default. I don't think we want to do this, because:

  1. Both fields are optional, so we don't need to provide values.
  2. We don't actually know that the confidence is 1.0; I'd rather give nothing than make it up.

That said, just my opinion. Anyone have any strong(er) feelings on this?

urinieto commented 10 years ago

+1

justinsalamon commented 10 years ago

+1

ejhumphrey commented 10 years ago

I've gotten rid of all these things in the great Isophonics overhaul of 2014.