search

urinieto / msaf

Music Structure Analysis Framework
MIT License
501 stars 79 forks source link

Remove pre-existing NumPy requirement from setup.py #124

Closed carlthome closed 1 year ago

carlthome commented 1 year ago

What?

Make sure msaf can be installed in a new Python venv without first having to install NumPy.

Why?

Noticed that there were C/C++ extensions used in the past by MSAF, which is why import numpy has been needed, I guess? Since there doesn't seem to be any such install steps anymore, it would be convenient to not have to 

pip install numpy
pip install msaf

in sequence anymore. Especially for users who doesn't use Anaconda and prefer miniconda and/or pip wheels.

How?

This PR makes python -m venv .venv; .venv/bin/pip install msaf work by removing the import of numpy within the setup.py script.

urinieto commented 1 year ago

Thanks, that's a good catch! Seems like the installation is successful without the include_dirs, so I'll merge this.