search

urinieto / msaf

Music Structure Analysis Framework
MIT License
478 stars 79 forks source link

Use `cls` for classmethod argument #137

Closed carlthome closed 10 months ago

carlthome commented 10 months ago

Minor polish but self is reserved for the instance, so classmethods should not take in self but rather cls like in:

https://github.com/urinieto/msaf/blob/7fcedb4e80b000cc60818caf54f0ba9abe3de3f5/msaf/base.py#L453

Stems out of seeing warnings from the Python extension in VS Code.

urinieto commented 10 months ago

lgtm, thanks!