search

urinieto / msaf

Music Structure Analysis Framework
MIT License
501 stars 79 forks source link

Log progress in collection mode #138

Closed carlthome closed 1 year ago

carlthome commented 1 year ago

Just a proposal (feel free to close!).

When running MSAF on SALAMI, it takes a while to process every feature, but there's no visible output during msaf.run.process in collection mode, so I thought my computer had frozen/crashed.

Would be nice to see some progress reporting with TQDM or similar. Turns out joblib already has support for printing some progress in the style of the following:

[Parallel(n_jobs=4)]: Using backend LokyBackend with 4 concurrent workers.
[Parallel(n_jobs=4)]: Done  33 tasks      | elapsed:    5.3s
[Parallel(n_jobs=4)]: Done 154 tasks      | elapsed:  1.1min

This PR enables that.

urinieto commented 1 year ago

Fantastic, thanks!