Only load items once (reuse promise)

urish / angular-load

Dynamically load scripts and css stylesheets in your Angular.JS app

MIT License

243 stars 65 forks source link

Only load items once (reuse promise) #10

Closed dougmoscrop closed 9 years ago

dougmoscrop commented 9 years ago

This fixes https://github.com/urish/angular-load/issues/8

I considered using resolve-url to canonicalize the URLs, but did not want to introduce dependency and that can easily be a separate PR if wanted.

I also snuck in a 'build' script so that those of us without Grunt installed -g can just do npm run build.

coveralls commented 9 years ago

Coverage remained the same when pulling bdfab0fcb4d20aea5a725571b2a6271015ab9277 on dmoscrop:master into 24d661f5cab0eef78d35cb906616dedca75b0922 on urish:master.

urish commented 9 years ago

Looks good, thanks!

Very nice solution with npm run build instead of having to install Grunt globally.

About resolve-url - how about making the dependency optional?

Uri