urish / angular-load

Dynamically load scripts and css stylesheets in your Angular.JS app
MIT License
243 stars 65 forks source link

Use $q as a constructor. #20

Closed realityking closed 8 years ago

realityking commented 8 years ago

Note: This breaks compatability with Angular 1.2 and older. If that's not desiderable, just ignore this ;)

realityking commented 8 years ago

I've rebased the branch onto master to account for #19.

realityking commented 8 years ago

Any feedback on this?

urish commented 8 years ago

Sorry for not replying before :)

I'd rather keep compatible with Angular 1.2 unless there is a good reason not to... Do you see a very good reason to switch to this syntax?

Thanks!

realityking commented 8 years ago

Nope, it's only a minor improvement. Just wanted to try ;)

urish commented 8 years ago

Great, thank you for your time!