Make sure onreadystatechange callback is only fired when file is fully loaded

urish / angular-load

Dynamically load scripts and css stylesheets in your Angular.JS app

MIT License

243 stars 65 forks source link

Make sure onreadystatechange callback is only fired when file is fully loaded #23

Closed davidchin closed 8 years ago

davidchin commented 8 years ago

In newer versions of IE, both onreadystatechange and onload callback gets fired (I assume onreadystatechange is there for backward compatibility). When onreadystatechange gets fired, we should check the state of the event, and only resolve the returned promise if readyState is 'complete'.

urish commented 8 years ago

Thanks!

davidchin commented 8 years ago

Thanks @urish, is it possible for you to bump up the version?

urish commented 8 years ago

Yes, will be done shortly

urish commented 8 years ago

Released as 0.4.0