Added IE8 support to script loading

urish / angular-load

Dynamically load scripts and css stylesheets in your Angular.JS app

MIT License

243 stars 65 forks source link

Added IE8 support to script loading #26

Closed benmarch closed 8 years ago

benmarch commented 8 years ago

I know you aren't supporting IE8, but this addition adds support as well as fixes inconsistent behavior in IE9 and 10. In IE10 we noticed that on the first page load this script would fail (callback wouldn't execute) but every page load thereafter worked fine. This change seems to make it work consistently, although I can't really explain why :) It would be really helpful for us if you could include this patch.

Thanks! Ben

urish commented 8 years ago

Looks good, thanks!

benmarch commented 8 years ago

Thank you for the incredibly fast response!! Please let me know when you are able to create a release for this change.

urish commented 8 years ago

Sure thing!

urish commented 8 years ago

Released as 0.4.1

benmarch commented 8 years ago

Thanks, @urish!!