search

urish / angular-load

Dynamically load scripts and css stylesheets in your Angular.JS app
MIT License
243 stars 65 forks source link

Bower.json limits angularLoad to no greater then 1.5.x #43

Open mr-White opened 6 years ago

mr-White commented 6 years ago

I ran into an issue during a bower install that had some conflicts. I don't believe it's necessary to limit this module to less then 1.6.0

I tested the angularLoad service code in my current AngularJS 1.6.5 project by creating a new service and copying/pasting your code into it. The loadScript functions works wonderfully in 1.6.5

I'm assuming, you can remove the restriction from the bower.json file, as this module and service should function normally on 1.6.x

Maybe I'm wrong? I haven't tested any of the other functions (all I needed was the loadScript).

The code in question:

"dependencies": {
   "angular": ">=1.0.0 <1.6.0"
},

Change too:

"dependencies": {
   "angular": ">=1.0.0"
},

I can submit a PR if you wish.... just let me know

phw commented 6 years ago

Agreed, seems to work for me with Angular 1.6