search

urish / angular-moment

Moment.JS directives for Angular.JS (timeago and more)
MIT License
2.6k stars 397 forks source link

Make AMD and commonjs consistant #261

Closed graingert closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.8%) to 91.928% when pulling ef236c6983904359d5617f7df7d1523334e68059 on graingert:patch-1 into 7798910c528d910fc431705c88919355de066300 on urish:master.

urish commented 8 years ago

Thanks!

I'd go with a different approach, where the angularMoment function itself will return the module name, and then both AMD and CommonJS will just use its return value directly. Thoughts?

urish commented 8 years ago

Fixed in commit 919882e