search

urish / angular-moment

Moment.JS directives for Angular.JS (timeago and more)
MIT License
2.6k stars 397 forks source link

Clarify documentation regarding moment injection #267

Open kibertoad opened 7 years ago

kibertoad commented 7 years ago

Current documentation makes it extremely unclear that while you do inject "angularMoment" into your module, you do not inject it where you intend to use it (e. g. service or controller), you inject "moment" instead.

The only place where I found that mentioned was https://github.com/urish/angular-moment/issues/236 , while it should definitely be mentioned loud and clear in the main documentation in example part. :)

jwanglof commented 7 years ago

Created a PR for this =) Thanks for the link to the other issue