search

urish / angular-moment

Moment.JS directives for Angular.JS (timeago and more)
MIT License
2.6k stars 397 forks source link

minor edit to the am-time-ago directive code snippet #270

Closed Jkim55 closed 7 years ago

Jkim55 commented 7 years ago

minor edit to the am-time-ago directive code snippet. Added .getTime() to ln 95 of readme

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.213% when pulling 2eb0ac83588fe43ea16c49e6658a7bb7544ae47e on Jkim55:readme into 448e472efb22bd51bdc210cf80c7d296b63e0aaa on urish:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.213% when pulling 2eb0ac83588fe43ea16c49e6658a7bb7544ae47e on Jkim55:readme into 448e472efb22bd51bdc210cf80c7d296b63e0aaa on urish:master.

Jkim55 commented 7 years ago

Hi! After finally figuring out I needed utc to use the am-time-ago directive, I thought this edit might be useful for those reading documentation on the am-time-ago directive code snippet. :D I hope it's helpful!

Ji

urish commented 7 years ago

Hi @Jkim55 , thank you for your contribution. Can you please explain how using new Date().getTime() helped in your case?

Jkim55 commented 7 years ago

opps- nevermind! Seems to work with the new Date, too.

urish commented 7 years ago

Thank you for your time. It is always inspiring to see newbies contributing and taking part in open source, and you seems to have a lot going on in your github account. Keep up the good work!

Jkim55 commented 7 years ago

Thanks for kind words! I'm so appreciative of js dev community, which I found to be supportive & open. 👍