search

urish / angular-spinner

Angular directive to show an animated spinner (using spin.js)
MIT License
693 stars 146 forks source link

Bower installing this package (even using git repo) results in wrong package installed? #106

Closed jawache closed 7 years ago

jawache commented 7 years ago

Hia,

Not sure what's going on, but bower installing either angular-spinner or the git repo directly results in the wrong angular-spinner getting installed https://github.com/angularifyjs/bower-angular-spinner.git.

About to jump on a flight but maybe this could be a name clash of some form?

➜  angularjs-migrate git:(master) ✗ bower install 'http://github.com/urish/angular-spinner.git'
bower angular-spinner#*     not-cached http://github.com/urish/angular-spinner.git#*
bower angular-spinner#*        resolve http://github.com/urish/angular-spinner.git#*
bower angular-spinner#*       checkout 1.0.1
bower angular-spinner#^1.2.26       not-cached https://github.com/angularifyjs/bower-angular-spinner.git#^1.2.26
bower angular-spinner#^1.2.26          resolve https://github.com/angularifyjs/bower-angular-spinner.git#^1.2.26
bower angular-spinner#^1.2.26         checkout v1.2.26
bower angular-spinner#*               resolved http://github.com/urish/angular-spinner.git#1.0.1
bower angular-spinner#^1.2.26         resolved https://github.com/angularifyjs/bower-angular-spinner.git#1.2.26
bower angular-spinner#^1.2.26          install angular-spinner#1.2.26

angular-spinner#1.2.26 src/libs/angular-spinner
ghost commented 7 years ago

The bower repo is not belong to this repo anymore. Bower install angular-spinner should work and it's mapping to https://github.com/Attrash-Islam/bower-angular-spinner

Give me the chance to deal with it (1 hour in the train heading to work)

ghost commented 7 years ago

@jawache What happened when you tried to run bower install angular-spinner ?

jawache commented 7 years ago

Thanks this is what I see @Attrash-Islam 

➜  angularjs-migrate git:(master) ✗ bower uninstall angular-spinner
bower uninstall     angular-spinner
➜  angularjs-migrate git:(master) ✗ bower cache clean                                          
bower deleted       Cached package angular-spinner: /Users/jawache/.cache/bower/packages/32d341c521a98cd1a570885a404bc89d/1.2.26
bower deleted       Cached package angular-spinner: /Users/jawache/.cache/bower/packages/da2f030654dbc42b2e76c4d3d29e30b8/1.0.1
➜  angularjs-migrate git:(master) ✗ bower install angular-spinner
bower angular-spinner#^1.2.26       not-cached https://github.com/angularifyjs/bower-angular-spinner.git#^1.2.26
bower angular-spinner#^1.2.26          resolve https://github.com/angularifyjs/bower-angular-spinner.git#^1.2.26
bower angular-spinner#*             not-cached https://github.com/Attrash-Islam/bower-angular-spinner.git#*
bower angular-spinner#*                resolve https://github.com/Attrash-Islam/bower-angular-spinner.git#*
bower angular-spinner#*               checkout v1.0.1
bower angular-spinner#^1.2.26         checkout v1.2.26
bower angular-spinner#^1.2.26         resolved https://github.com/angularifyjs/bower-angular-spinner.git#1.2.26
bower angular-spinner#*           invalid-meta The "main" field cannot contain minified files
bower angular-spinner#*               resolved https://github.com/Attrash-Islam/bower-angular-spinner.git#1.0.1
bower angular-spinner#^1.2.26          install angular-spinner#1.2.26
jawache commented 7 years ago

Ahh nevermind, I removed the entry from bower.json, uninstalled, cleaned and installed again and it works now! Resolves to the right package and I see a dist folder with the angular-spinner.js file.

Not sure if you fixed something or I was being dumb but thanks for the quick response!

ghost commented 7 years ago

Happy for helping you :smiley: