search

urish / angular-spinner

Angular directive to show an animated spinner (using spin.js)
MIT License
693 stars 146 forks source link

Added overlay #109

Open sprycoder opened 7 years ago

sprycoder commented 7 years ago

Hi Uri

I have added overlay on older angularjs spinner. Please merge it on angularjs-spinner-overlay branch. Few folks are still working on angularjs version, so it will be helpful for them.

Please let me know your thoughts, if it doesn't seem fit to you.

Thanks Vikas Vaidya

ghost commented 7 years ago

Can you please ammend your commit with conflicts resolves? I think you didn't rebased the codebase a while ago

sprycoder commented 7 years ago

Thanks for replying on it.

This pull request is not on latest branch. This pull request is having an overlay implementation for angularjs code on branch 0.8.1.

As few people are still working on angularjs 1.x. So it will be helpful for them.

Please update this pull request on branch 0.8.1 only.

Thanks Vikas

On 1 Aug. 2017 21:35, "Islam Attrash" notifications@github.com wrote:

Can you please ammend your commit with conflicts resolves? I think you didn't rebased the codebase a while ago

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/urish/angular-spinner/pull/109#issuecomment-319345425, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ9m4sv65H3BjobVzIDCW6Dtv7Uvu0IKks5sTw1pgaJpZM4OpYVu .