Fix: always applies latest theme

urish / angular-spinner

Angular directive to show an animated spinner (using spin.js)

MIT License

693 stars 146 forks source link

Fix: always applies latest theme #78

Closed Bonerdelli closed 7 years ago

Bonerdelli commented 8 years ago

When multiple themes configured by usSpinnerConfigProvider, actually only last applies for all spinners

urish commented 8 years ago

Thanks!

Can you also add a test case for this? It should be a test case that failed before the fix and passes after applying the fix.

ghost commented 7 years ago

Hi @Bonerdelli , Thanks for your contribution.

We've decided to refactor the whole code base because of the many requests of webpack and amd compatibility issues, and we're using already webpack in master branch (+TypeScript).

Can you please fix this with the new code-base in master so we can merge it?

ghost commented 7 years ago

Closing for deprecated pull-requests