urish / angular-spinner

Angular directive to show an animated spinner (using spin.js)
MIT License
693 stars 146 forks source link

I've got some installation issue #91

Closed heygema closed 7 years ago

heygema commented 8 years ago

After I have done with bower install -> include scripts -> not yet included in module

this happens in my console

angular-spinner.js:15 Uncaught TypeError: Cannot read property 'module' of undefinedfactory @ angular-spinner.js:15(anonymous function) @ angular-spinner.js:136(anonymous function) @ angular-spinner.js:138
main.controller.js:21

If I add to the app.module the angularSpinner dependency are simply not defined.

I think the problem is from the angular-spinner.js source. thank you.

ghost commented 7 years ago

Hi @heygema , Thanks for reporting

We've decided to refactor the whole base code because of the many requests of webpack and amd compatibility issues, and we're using already webpack in master branch (+TypeScript).

When we publish the new release in the next days you won't encounter any installation issues

heygema commented 7 years ago

Thanks for your concern, webpack is awesome.

ghost commented 7 years ago

Absolutely!