Add webpack support - Githubissues

urish / angular-spinner

Angular directive to show an animated spinner (using spin.js)

MIT License

693 stars 146 forks source link

Add webpack support #93

Closed ivanp closed 7 years ago

ivanp commented 7 years ago

Add support for webpack by checking if __webpack_require__ is there.

coveralls commented 7 years ago

Coverage decreased (-1.7%) to 94.545% when pulling a1563a71678517d86a28bd12db5bff1af08580fd on ivanp:master into 6cbf56991eb21756597ca675bbde804db136cbb5 on urish:master.

ghost commented 7 years ago

Thanks @ivanp for your pull-request.

We've decided to refactor the whole base code because of the many requests of webpack and amd compatibility issues, and we're using already webpack in master branch (+TypeScript).

Unfortunately, I'll close this pull-request and you're welcome to participate and send your feedback regards the new code

Thanks a lot, and I'm grateful for your contribution :+1: