search

urish / ngx-moment

moment.js pipes for Angular
MIT License
1.17k stars 154 forks source link

Improve documentation for locale import. #193

Closed davemecha closed 6 years ago

davemecha commented 6 years ago

When I used the amLocale pipe, I was struggeling with getting the locale loaded. When I did something like

{{ myMoment | amLocale:'de' | amDateFormat:'MMMM' }}

to show the month of a date, I always got the english name of the month. After searching the issues, I found https://github.com/urish/ngx-moment/issues/149#issuecomment-315011495, what finally helped me. I checked my node_modules that moment was installed and just did the import. I didn't test in my project, if the manual installation of moment.js is necesssary on a clean project.

I think, it would improve the documentation, if this note is added.

urish commented 6 years ago

Awesome, thanks!