urish / ngx-moment

moment.js pipes for Angular
MIT License
1.17k stars 154 forks source link

ModuleWithProviders usage without type parameter no longer supported in angular 10. #240

Closed FrancisS closed 4 years ago

FrancisS commented 4 years ago

https://github.com/urish/ngx-moment/blob/ba26f85b6eebc75b65ba85739ba3e74ea5dee648/src/moment.module.ts#L45

Support for using the ModuleWithProviders without a generic parameter has been removed as of angular 10. ngx-moment no longer compiles with angular 10.

node_modules/ngx-moment/moment.module.d.ts:4:49 - error TS2314: Generic type 'ModuleWithProviders' requires 1 type argument(s).

4 static forRoot(options?: NgxMomentOptions): ModuleWithProviders;

urish commented 4 years ago

Thank you!

urish commented 4 years ago

Released as 5.0.0