uriyacovy / ESPHome_nuki_lock

ESPHome lock platform for Nuki Smartlock
MIT License
60 stars 19 forks source link

Increase speed and reliability by orders of magnitude #36

Closed zanna-37 closed 5 months ago

zanna-37 commented 5 months ago

I created this PR mainly to address these issues: #26, #16, and I-Connect/NukiBleEsp32#37.

It's a bit of code, but I made sure that every commit is self-contained and commented on. I suggest reviewing this PR by going commit by commit, and not only the final result.

Features:

For best results, I recommend decreasing NukiBleEsp32 CMD_TIMEOUT as I did in this commit: https://github.com/zanna-37/NukiBleEsp32/commit/1677425e9e6bd484e1abb0669b7d9d23259ecb23

~I'm marking this PR as a draft in order to have some days in which I will further test the code.~ I tested this for 3 weeks and it's working properly. Any opinion is welcome. And thanks for this amazing repo!

zanna-37 commented 5 months ago

@uriyacovy I tested it for quite some days now and I confirm that it is stable and can be merged.

uriyacovy commented 5 months ago

Looks great @zanna-37, thanks for you contribution! And of course, apologizes for the delay.