Closed mapero closed 2 years ago
Hi @mapero,
Great contribution, thanks! Two things I noticed that should be fixed before pulling:
this->door_sensor_->publish_state
but please have a look. It is better not to have breaking changes if they can be avoided.Thanks, Uri
Hi @uriyacovy
thanks for the feedback. I have changed the code for the optional sensors (also for the existing ones, they had the same problem) to only publish in case they are present in the configuration.
Updated readme and screenshot accordingly.
Regards Jochen
Looks very good, thanks.
Hi,
i added two additional sensors to represent the door sensor.
To map the nuki states to a binary sensor, I decided to use DoorClosed as "false" and all other cases as "true". This ensures that if there is something wrong with the door sensor, it shows open instead of closed (more secure).
Thanks for providing this custom component.
best regards Jochen