Closed moumoutte closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.69%. Comparing base (
245519c
) to head (bcb3f35
). Report is 270 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If I understand properly your comment, you ask me if I could add the count_query
param to the ext.sqlalchemy.paginate
function ?
I think this param is already present here : https://github.com/uriyyo/fastapi-pagination/blob/main/fastapi_pagination/ext/sqlalchemy.py#L241 and here https://github.com/uriyyo/fastapi-pagination/blob/main/fastapi_pagination/ext/sqlalchemy.py#L226
Only the function marked as deprecated
has no count_query
param.
I guess this is a good thing to not maintain a feature on deprecated function. But if you really want to it , I could provide it. Let me know !
@moumoutte My bad, I forgot that it already has count_query
param 😅
@moumoutte Thanks for PR!
Do not use the boolmethod of count_query as it's not evaluating to a boolean here and instead detect if it's None or not. Also add the count_query as a valid parameter of
fastapi_pagination.ext.sqlmodel.paginate