Move extensions to separate packages

uriyyo / fastapi-pagination

FastAPI pagination 📖

https://uriyyo-fastapi-pagination.netlify.app/

MIT License

1.1k stars 127 forks source link

Move extensions to separate packages #304

Closed uriyyo closed 1 year ago

uriyyo commented 2 years ago

Extensions:

[ ] async_sqlalchemy
[ ] async_sqlmodel
[ ] asyncpg
[ ] databases
[ ] django
[ ] gino
[ ] mongoengine
[ ] motor
[ ] orm
[ ] ormar
[ ] piccolo
[ ] sqlalchemy
[ ] sqlalchemy_future
[ ] sqlmodel
[ ] tortoise

johnziebro commented 2 years ago

Possibly include Beanie which seems like an excellent candidate in that it extends Motor and Pydantic and works well with FastApi.

TamiasSibiricus commented 2 years ago

I have created new issue for beanie #334 before find proposal here. Solution will coming soon.

TamiasSibiricus commented 2 years ago

But is it real requirement to move extensions each one to separate package? In this case each package will contain only one file with one function. Seems like hyperfragmentation and hard to maintain. I think any coder can write own extension and just pull request here.

uriyyo commented 1 year ago

@TamiasSibiricus Because of gino package there were dependency conflicts between other packages. After removing it from the dependencies list seems like this issue is no longer needed.