uriyyo / pycharm-evaluate-async-code

Finally, you can use await in evaluate expression 💪
https://plugins.jetbrains.com/plugin/14476-evaluate-async-code
44 stars 2 forks source link

Any plan to support trio? #71

Closed seidnerj closed 7 months ago

seidnerj commented 11 months ago

If you could point me in the right direction I might be able to implement this myself and add a PR.

Thanks in advance

uriyyo commented 7 months ago

Hi @seidnerj,

Sorry for long response, I will try to figure out, if it's possible to have integration with trio.

uriyyo commented 7 months ago

Hi @seidnerj,

New version 1.24 has initial trio integration. It will be great if you can try it out)

seidnerj commented 7 months ago

Hey Yurii, By the way, how does your plugin interplay with the (now builtin) support:

https://youtrack.jetbrains.com/issue/PY-57667/Asyncio-support-for-the-debugger-EXPERIMENTAL-FEATURE

uriyyo commented 7 months ago

It's actually works as expected. Because plugin replaces default debugger implementation with custom one. The custom implementation is not affected by this new built-in feature.

Actually, I checked out what their implementation looks like and I guess they took idea of initial implementation from my plugin (at least it looks very similar). The idea was to use nest-asyncio package to allow to run coroutines inside running event loop.

But this plugin solved a lot of issues and did not use nest-asyncio package anymore.

Things that are solved by this plugin and not solved by built-in implementation (that I have found in latest PyCharm EAP):

seidnerj commented 7 months ago

Great, I am using it right now. So far, so good! 🙏

uriyyo commented 7 months ago

Great, I am closing this issue. Please, open a new one if you will gonna find some bugs.

seidnerj commented 7 months ago

Will do! 🙏