search

urls / url-shortener-php

Web application that will help you in shortening your url
http://urls.github.io/url-shortener
MIT License
88 stars 74 forks source link

Minor improvements. #10

Closed amalmurali47 closed 7 years ago

amarlearning commented 7 years ago

@amalmurali47 everything LGTM :+1: Thanks!

amalmurali47 commented 7 years ago

@amarlearning: Cool. I couldn't really find anything that I could improve upon. Except maybe abstracting away all the database connection details into a different config file in JSON or something. Thoughts?

amarlearning commented 7 years ago

@amalmurali47 well we can do that! But this leaves a negligible impact on feature and Performance.

I have some ideas to implement, but I don't have time. If you want I can help you in this.

amalmurali47 commented 7 years ago

Sure. What are the ideas?

On Fri, Dec 30, 2016 at 3:03 AM, Amar Prakash Pandey < notifications@github.com> wrote:

@amalmurali47 https://github.com/amalmurali47 well we can do that! But this leaves a negligible impact on feature and Performance.

I have some ideas to implement, but I don't have time. If you want I can help you in this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/urls/url-shortener/pull/10#issuecomment-269696877, or mute the thread https://github.com/notifications/unsubscribe-auth/ADaokAKMcxj6M0IbwyoLgs2wru-LKV4Gks5rNCcogaJpZM4LX2Ks .

amarlearning commented 7 years ago

@amalmurali47 cool :+1:

  1. Instead of shortening a single URL there should an extended feature to shorten multiple URLs in a single click.
  2. URL analytics.

Let me know if you need any help!