urls / url-shortener-php

Web application that will help you in shortening your url
http://urls.github.io/url-shortener
MIT License
87 stars 74 forks source link

Refactor for PDO & Modularity #15

Open runninguru opened 6 years ago

runninguru commented 6 years ago

PDO would allow this to be database-agnostic, and while it's refactored to support PDO, it should be implemented in a more modular way.

I've cloned the project and partially finished these changes. If you want, we could create a branch and I could push my current changes to it so we can work on it before pushing it to the master branch.

amarlearning commented 6 years ago

I've cloned the project and partially finished these changes. If you want, we could create a branch and I could push my current changes to it so we can work on it before pushing it to the master branch.

@runninguru Great! Let me know when you are done with the changes.

runninguru commented 6 years ago

I'm finished with the changes. If you create a branch, I can make a pull request to that branch so you can review what i've done before you merge it with the master branch.

amarlearning commented 6 years ago

@runninguru you can push your changes in the develop branch for the review.