search

urob / adv360-demo-config

ZMK configuration for Advantage 360 pro
19 stars 47 forks source link

Difference between this zmk and mainstream zmk #1

Open yanshay opened 1 year ago

yanshay commented 1 year ago

I'm using this config and the zmk version behind it instead of Advantage 360 original config. It fixes a bug in the original Advantage version and has more capabilities (like Mouse) so I find it much better. I noticed some strange difference. The RCMD with this setup isn't caught by karabiner elements while the RCMD with the original Advantage config does. In Karabiner Even Viewer both seem the same, so it probably means there are lower level details that differentiate the actual key press my Mac see. What could be the source of such difference? What tool for Mac can show all the details on key presses that arrive to the Mac to troubleshoot?

yanshay commented 1 year ago

I found the reason for this, karabiner elements was disabled for the keyboard. When I enabled it it worked however caused other issues (those I think are a bug in zmk mod-morph, but maybe in karabiner elements). I'm trying to seek assistance on zmkfirmware/zmk#1685, maybe you can help?

urob commented 1 year ago

I don't know how Karabiner works, so I can't say anything about that. Regarding the issue with mod-morph: One of the differences between this repo and the official kinesis one is that it adds the 360 driver in a "modular way": Specifically, you can toggle between a more or less "barebones ZMK" firmware and a version with all the 360-specific code by switching between adv360 and adv360-led on line 10 of config/west.yml: https://github.com/urob/adv360-demo-config/blob/39d025f5bdf329ce28399bfe7d1edec30efb6a5b/config/west.yml#L10

If you set the revision to adv360 then this repo builds the firmware using almost standard ZMK code. If the bug that you are describing still occurs in this case, then it is likely a bug with mod-morph. In this case it would be great if you could file a bug report with the official ZMK repo.

On the other hand, if you switch to the adv360-led branch in config/west.yml, then you are getting all the custom led functionality. The result should be very similar to what you are getting with the official kinesis repo. If the bug occurs with this branch, then the source is the custom led code from Polaris. If not, then something else must be wrong in the official kinesis implementation. In either case, you should file a bug report with Polaris. But hopefully, using this procedure, you can at least pin down whether its an issue with the actual led-driver or just something odd they do in their repo.