urob / zmk-helpers

Convenience macros simplifying ZMK's keymap configuration
MIT License
235 stars 79 forks source link

keypos for kyria keyboardd #16

Closed mateuszaaa closed 1 year ago

urob commented 1 year ago

Thanks for working on this! I would label the keys slightly differently to make sure that LB0-LB5 and RB0-RB5 still correspond to the same position as on other boards. E.g., LB2 should correspond to the middle-finger on the left-bottom row. Otherwise, combos won't be invariant to switching boards by just swapping out the definition file. For example, something like this:

╭─────────────────────────────────┬─────────────────────────────────╮
│ LT5 LT4 LT3 LT2 LT1 LT0         │         RT0 RT1 RT2 RT3 RT4 RT5 │
│ LM5 LM4 LM3 LM2 LM1 LM0         │         RM0 RM1 RM2 RM3 RM4 RM5 │
│ LB5 LB4 LB3 LB2 LB1 LB0 LF1 LF0 │ RF0 RF1 RB0 RB1 RB2 RB3 RB4 RB5 │
╰───────────╮ LH4 LH3 LH2 LH1 LH0 │ RH0 RH1 RH2 RH3 RH4 ╭───────────╯
            ╰─────────────────────┴─────────────────────╯

NB: I am not sure what's the best label for the two extra inner keys on the bottom row. I suggested LF0, LF1, RF0, RF1 as they are already used on one other board (standing for "floor" row). But I am open to other naming schemes as long as all keys on the "core positions" are consistently named.

Thanks again!

If that makes sense, if you could update the PR, it would be great to get it in.

urob commented 1 year ago

Superseded by #19