search

urob / zmk-helpers

Convenience macros simplifying ZMK's keymap configuration
MIT License
235 stars 79 forks source link

added modifications for lily58 & encoder #7

Closed laureyn closed 1 year ago

laureyn commented 1 year ago

Hi @urob,

I created a keypos file for my Aurora lily58, and also added overloading possibilities for the layer macro (to add the encoder volume up & down).

(example on how to use the macro can be found in my repo https://github.com/laureyn/zmk-config/blob/repair/config/splitkb_aurora_lily58.keymap , I am still working on my mapping though)

urob commented 1 year ago

Great, thanks for adding this!

laureyn commented 1 year ago

I saw after that, that I didn't update the readme. Do you want me to create another PR?

urob commented 1 year ago

I saw after that, that I didn't update the readme. Do you want me to create another PR?

Thanks! I pushed one more commit with a little bit of explanation and a bit of refactoring. I also used your approach to add an optional fifth argument to ZMK_COMBO (replacing ZMK_COMBO_ADV).

It would be great though if you have another look to see if the changes to the documentation are clear (and to make sure I didn't inadvertently break something).

laureyn commented 1 year ago

Will do as soon as I have time! 👍