search

urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.
https://urql.dev/goto/docs
MIT License
8.6k stars 448 forks source link

chore(svelte): Increase peer dependency range for Svelte 4 #3302

Closed ategen3rt closed 1 year ago

ategen3rt commented 1 year ago

Resolves #3300

Summary

This allows the package to be installed in projects using svelte 4

Set of changes

Changed @urql/svelte Added Svelte ^4.0.0 as a peer dependency (in addition to the ^3.0.0 that was already there.

ptrxyz commented 1 year ago

I am using Svelte 4 since it's release and things seem to be fine. However, there are some breaking changes in Svelte 4, but I can't tell if they are relevant for urql: https://svelte.dev/docs/v4-migration-guide#other-breaking-changes

Mostly they are about typing and components and some minor internal. Should not affect urql.

kitten commented 1 year ago

Hiya, I don't think the breaking changes affect us.

However, can you please upgrade the dev dependency for Svelte here, so we're actually using the newest against the range?

We also have an example here that can be bumped and tested, so if that's updated I'll have a look before merging: https://github.com/urql-graphql/urql/tree/main/examples/with-svelte

Lastly, every PR that changes code will need a changeset, as per the contributing guide: https://github.com/urql-graphql/urql/blob/main/CONTRIBUTING.md#how-do-i-document-a-change-for-the-changelog This is to add changelog entries and to specify what version bump is required. In this case, a patch entry with a description along the lines of "Updated peer dependency range to include support for Svelte 4" will be enough.

Happy to take either of these over, but please let me know.

ategen3rt commented 1 year ago

I believe I did the tasks you mentioned correctly.

frederikhors commented 1 year ago

Hi @ategen3rt and @ptrxyz, I saw you're using Svelte too.

I can be an accurate and fast tester of svelte@4 with urql but I'm stucked with https://github.com/urql-graphql/urql/discussions/3304.

Can I ask for your help? Even just to figure out if I'm doing something wrong.