urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.
https://urql.dev/goto/docs
MIT License
8.6k stars 448 forks source link

persistedExchange duplicates operations #3311

Closed geekuillaume closed 1 year ago

geekuillaume commented 1 year ago

Describe the bug

Enabling the new persisted exchange breaks the queries deduplication. This happens both when the persisted query is already registered on the server and also when the query is not yet registered and the server returns a PersistedQueryNotFound error.

Reproduction

https://codesandbox.io/s/urql-persisted-exchange-query-duplication-bug-repro-hnfjyr

Urql version

urql@4.0.4 @urql/exchange-persisted@4.0.0

Validations

geekuillaume commented 1 year ago

@kitten thanks for this incredible response time :) Urql is awesome and we're using it extensively at Vizcom. We're super happy to give a little back to the community and you for your awesome work!

kitten commented 1 year ago

@geekuillaume That's kind and awesome of you! ❤️ I'm glad you're happy and I'm sorry if this regression caused you any trouble. I'm not sure how I missed this during the refactor