Duplicated requests even for older queries using `requestPolicyExchange` with 6.1.5-canary

[frederikhors]

Describe the bug

@kitten, as usual I cheered too soon before discovering ONE DIFFERENT PROBLEM probably brother of the other.

Steps:

1. Start the backend visiting: https://codesandbox.io/p/sandbox/h1pcl

2. Open the frontend reproduction: https://stackblitz.com/edit/sveltejs-kit-template-default-y5hteh

3. Go to "List"

4. Wait for the list to appear

5. Open browser Dev tools on the "Network" panel

6. Click on the button "Complete" on one todo

7. The first call starts and after some seconds it finishes

8. AND NOW THE NEW PROBLEM (with "6.1.5-canary-7ddccc13" at least):

9. Another call starts! For every action, even if you click on the "Add more random todos" button.

I'm sad again! :LOL:

Urql version

"devDependencies": {
    "@sveltejs/adapter-auto": "2.1.0",
    "@sveltejs/kit": "1.22.3",
    "@urql/core": "4.0.11",
    "@urql/exchange-request-policy": "1.0.2",
    "@urql/exchange-graphcache": "6.1.5-canary-7ddccc13",
    "@urql/exchange-persisted": "4.0.1",
    "@urql/exchange-retry": "1.2.0",
    "@urql/svelte": "4.0.3",
    "prettier": "^2.8.0",
    "prettier-plugin-svelte": "^2.10.1",
    "svelte": "3.59.2",
    "svelte-check": "3.4.6",
    "svelte-preprocess": "^5.0.4",
    "tslib": "2.6.0",
    "typescript": "5.1.6",
    "vite": "4.4.4"
},

Gif

Validations

• [X] I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
• [X] Read the docs.
• [X] Follow our Code of Conduct

[frederikhors]

Sorry. I think it was the requestPolicyExchange which I don't need.

[frederikhors]

I think this deserves your checking, @kitten. Because it is strange what is happening.

Even though I'm using requestPolicyExchange I think it doesn't have to reload queries I'm not calling:

requestPolicyExchange({
  ttl: 1,
  shouldUpgrade: (e) => {
    console.log("test, e:", e);
    return true;
  }
}),

[kitten]

This is expected behaviour. You've set the requestPolicyExchange to ttl: 1, which practically means that every operation will be upgraded to cache-and-network. This in turn means that when the todo list is refreshed after the mutation, its operation is upgraded to cache-and-network

You can even see in the network tab that it's the list query after:

If you increase the TTL, the new request will not be made until the TTL is expired

[frederikhors]

I thought the requestPolicyExchange was only for queries that the user triggers, not for queries that have already finished. In this case the list query is already finished and so I thought it would hang until I call it (and in that case it checks the TTL).

Okay. Now I understand that this exchange operates differently.