fix(graphcache): Cascade `@defer`, `@_optional`, and `@_required` state only per nested fragment spread

urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.

MIT License

8.54k stars 444 forks source link

Summary

This fixes @_optional to work when the selection contains a sub-selection fragment spread. Previously, other fragment spreads inside an @_optional spread would become non-optional/non-required again, since the value of deferRef would be reset with another isOptional() check.

This also applies the same principle to @defer. Previously, @defer would cascade to all child selection fields. This meant that any field nested inside a @defer-ed fragment would be able to be deferred and be completely optional, even if it's direct parent wasn't a deferred fragment spread.

Set of changes

Remove deferRef reset from makeContext
Reset deferRef with every new child field and only cascade it across fragment spreads
Cascade optionalRef across fragment spreads (but also not new child fields)
Add overload signature to annotate what the preferred call signature of makeSelectionIterator is to prevent future mistakes

urql-graphql / urql

fix(graphcache): Cascade `@defer`, `@_optional`, and `@_required` state only per nested fragment spread #3517

Summary

Set of changes

🦋 Changeset detected