fix(request-policy): avoid relying on cache internals to assert misses

urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.

MIT License

8.54k stars 444 forks source link

Resolves #3508

Summary

This PR removes the logic of asserting the cacheState of a given operation and moves us to asserting whether the operation was resolved synchronously. When we are dealing with a synchronously resolved operation we can see this as a cache-hit, when it's higher than the last dispatched we can see this as a cache miss.

## Operation with cache-first
cache-first --> request-policy (time 1) --> cache-miss --> fetch --> request-policy (time x > 1)
## Operation with cache-and-network
cache-and-network--> request-policy (time 1) --> cache-hit --> request-policy (time = 1) --> fetch --> request-policy (time x > 1)

urql-graphql / urql

fix(request-policy): avoid relying on cache internals to assert misses #3521

Summary

🦋 Changeset detected