fix(core): Fix `@ts-ignore` directive on TS import in type declaration output

urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.

https://urql.dev/goto/docs

MIT License

8.54k stars 444 forks source link

fix(core): Fix `@ts-ignore` directive on TS import in type declaration output #3567

Closed kitten closed 2 months ago

kitten commented 2 months ago

See: https://github.com/0no-co/graphql.web/pull/27

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 513a31e2fe45fcbe4f71af4c6cff426d8946d9a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ---------- | ----- | | @urql/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

IvanUkhov commented 2 months ago

I think you forgot to update the dependency on 0no-co/graphql.web. It still depends on the version with that problem.

kitten commented 2 months ago

@IvanUkhov It's within range: https://github.com/urql-graphql/urql/blob/de4081b2637d2a882425c9395ee5f95a4a6220d3/packages/core/package.json#L57 Typically, I wouldn't bump that unless there's an explicit reliance on changes in the sub-package (like API changes). Since it's in range and the fix isn't preventing anyone from using it (i.e. if it's discovered, I'd hope the first thing someone does is to upgrade the broken dependency transitively). especially since skipLibCheck in TS is common I'd just leave it be

IvanUkhov commented 2 months ago

Good point. People will figure out to update if case they bump into this issue.