search

urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.
https://urql.dev/goto/docs
MIT License
8.54k stars 444 forks source link

chore: change `global` -> `globalThis` in tests #3590

Closed marvinhagemeister closed 1 month ago

marvinhagemeister commented 1 month ago

Summary

This is more of a maintenance change. The Node docs officially recommend to switch to globalThis instead of global, see https://nodejs.org/api/globals.html#global . globalThis is available in all other runtimes as well which makes the test suite easier to run outside of node. I'm working on getting vitest to run in Deno and I'm using urql's test suite for that.

Set of changes

Replaces usages of global in the test suite to globalThis.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 5243473ef94c1810e78704f4eb4d04c5e5643051

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR