Use shallowRef instead of ref for deep objects

urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.

MIT License

8.54k stars 444 forks source link

Summary

Instead of using ref for deep objects, it is much more efficient from a performance point of view to look at reactivity only at the moment of setting the value, rather than changing its internal properties.

Set of changes

Replaces ref with shallowRef for the client in useClient.ts
Replaces ref with shallowRef for error, operation and extensions in useMutation.ts, useQuery.ts and useSubscription.ts

I don't consider this a breaking change since these properties should always be considered read-only. Since properties are always overwritten completely, and nested reactivity is not needed in them. Because changing them will not lead to the desired result in most cases.

urql-graphql / urql

Use shallowRef instead of ref for deep objects #3611

Summary

Set of changes

🦋 Changeset detected