fix(vue): variables lose reactivity

urql-graphql / urql

The highly customizable and versatile GraphQL client with which you add on features like normalized caching as you grow.

https://urql.dev/goto/docs

MIT License

8.54k stars 444 forks source link

fix(vue): variables lose reactivity #3614

Closed JoviDeCroock closed 2 weeks ago

JoviDeCroock commented 2 weeks ago

Summary

Reverts #3612 and adds a test asserting this behavior for the future Re-opens #3507

We need to identify what specifically causes #3507 to keep allocating new helpers, this might as well be a bug in Vue as multiple libraries seem to leverage this pattern of calling reactive on a top-level argument.

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: e55fcb81d4e60bd692e7f33f5950a0c2bbed2164

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------- | ----- | | @urql/vue | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR