urquico / portfolio

Personal Portfolio developed using NextJS
https://urquico.vercel.app/
1 stars 0 forks source link

Sweep: on main branch, create a `types` folder and relocate all `types` and `interfaces` inside the `types` folder #55

Open urquico opened 5 months ago

urquico commented 5 months ago

Details

Here are the steps:

  1. Create a branch named refactor/types
  2. Create a folder named types; this should be inside src/lib/
  3. Check all .ts and .tsx files, check if there is an interface or type used.
  4. if there are, get the name of the type then use it as a file name, ex: type PersonType, the file should be named as person-type.ts
  5. After creating the file, put the type inside that file.
  6. Do not forget to import the file on the implementation of that type or interface.
Checklist - [X] Create `src/lib/types/project-data.ts` ✗ https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/lib/types/project-data.ts) - [X] Modify `src/lib/constants/project-data.ts` ✓ https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/lib/constants/project-data.ts) - [X] Create `src/lib/types/experience-data.ts` ✗ https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/lib/types/experience-data.ts) - [X] Modify `src/lib/constants/experience-data.ts` ! No changes made https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/lib/constants/experience-data.ts) - [X] Create `src/lib/types/maintenance-message.ts` ✗ https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/lib/types/maintenance-message.ts) - [X] Modify `src/lib/constants/maintenance-message.ts` ! No changes made https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/lib/constants/maintenance-message.ts) - [X] Create `src/lib/types/testimonial.ts` ✗ https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/lib/types/testimonial.ts) - [X] Modify `src/app/me/about/Carousel.tsx` ! No changes made https://github.com/urquico/portfolio/commit/d3695aeb726577eb04618455088596dbe659d615 [Edit](https://github.com/urquico/portfolio/edit/sweep/on_main_branch_create_a_types_folder_and/src/app/me/about/Carousel.tsx)
sweep-ai[bot] commented 5 months ago

🚀 Here's the PR! #56

See Sweep's progress at the progress dashboard!
💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 91d6cc7752)

[!TIP] I can email you next time I complete a pull request if you set up your email here!


Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I think are relevant in decreasing order of relevance (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/urquico/portfolio/blob/e55790030906819232da17a0eae8eeefd2bbc5f8/src/lib/constants/project-data.ts#L1-L317 https://github.com/urquico/portfolio/blob/e55790030906819232da17a0eae8eeefd2bbc5f8/src/lib/constants/experience-data.ts#L1-L43 https://github.com/urquico/portfolio/blob/e55790030906819232da17a0eae8eeefd2bbc5f8/src/lib/constants/maintenance-message.ts#L1-L26 https://github.com/urquico/portfolio/blob/e55790030906819232da17a0eae8eeefd2bbc5f8/src/app/me/about/Carousel.tsx#L1-L81

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/on_main_branch_create_a_types_folder_and.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To recreate the pull request edit the issue title or description. Something wrong? Let us know.

This is an automated message generated by Sweep AI.