search

ursachec / CPAProxy

A thin Objective-C wrapper around Tor.
Other
161 stars 49 forks source link

Remove precompiled dependencies from repo #3

Closed chrisballinger closed 10 years ago

chrisballinger commented 10 years ago

It's somewhat dangerous to ship compiled versions of these libraries, however, compiling OpenSSL for 5 architectures takes 30+ minutes on my machine so I can understand.

ursachec commented 10 years ago

Very good point @chrisballinger . Actually I added the dependencies so that users that clone the repo can get a quick demo up and running. Will add this to the README

chrisballinger commented 10 years ago

I'm going to submit a pull request that removes them and replaces your build scripts with the ones I use for OnionKit that include GPG verification of the source code (forked from Mike Tigas's iOS Onion Browser).

ursachec commented 10 years ago

Sounds great :thumbs_up:

chrisballinger commented 10 years ago

Actually I like your build scripts more than my old ones, but I needed to modify them to build OpenSSL 1.0.1i, libevent 2.0.21-stable, and Tor 0.2.5.8-rc for all of the available architectures on the iOS 8 SDK (see https://github.com/chrisballinger/CPAProxy/commit/91fecc8485bbea553151d1cc60a251469dbe3db0). I'm still going to re-add GPG verification as well.

If I get a chance, I'd like to also make the build scripts support the Mac OS X platform target as well. Running Tor in a network-only sandboxed NSXPC process would probably be a good idea when integrating it into desktop applications.

Next step will be finishing up Cocoapods and Travis-CI integration, before I submit a more substantial pull request.

chrisballinger commented 10 years ago

Fixed in ec12ba2ea327abcee576cd56b6dd454687d8ef28