urschrei / polylabel-rs

A Rust implementation of the Polylabel algorithm, with FFI.
https://docs.rs/polylabel
Other
54 stars 8 forks source link

Migrate to 2021 edition #15

Closed urschrei closed 1 year ago

urschrei commented 3 years ago

Just a low-stakes experiment. So far:

cargo fix --edition errored when trying to determine the Drop trait status on geo-types::Point (no idea either). Not a problem in practice because no changes were required to the crate's code, but something seems to be wrong with the tool.

The standard GH actions test runner hasn't migrated to 1.56 yet, so the 2021 edition tag causes a test run failure. Not that there's a rush, I'm not clear as to whether Cargo < 1.56 is getting a backport to ignore the 2021 edition value, or whether it's designed not to build. If the latter, we'd have to wait at least two release cycles (til 1.58 becomes available, giving us three versions to test against) to switch to the new edition, and bump our MSRV to 1.56 – again, not sure whether there's any upside to doing that at the moment.